Issue with hggroup and zlim

[dbateman]

John W. Eaton wrote:
> 
> Looking at __add_datasource__.m, I see
> 
>   i = 1;
>   newargs = {};
>   while (i < numel (varargin))
>     arg = varargin{i++};
>     if (ischar (arg) && length (arg > 1) && strcmpi (arg(2:end),
> "datasource"))
>       arg = tolower (arg);
>       val = varargin{i++};
>       if (ischar (val)) 
> 	set (h, arg, val);
>       else
> 	error ("%s: expecting data source to be a string", fcn);
>       endif
>     else
>       newargs{end + 1} = arg;
>     endif
>   endwhile
> 
> Should the test in this loop be <= instead of < ?  If so, then newargs
> will contain the parent argument and the calls to __line__ in plot3
> will need to be modified.  For example, I would propose this change:
> 

No as property/value occur in pairs. However varargin{i++} should read
varargin{++i} or i should be initialized to 0. As for the change in plot3.m
this is incorrect as the explicit reparenting to the hggroup is needed. Your
second reparenting will just override that.

D.

-- 
View this message in context: http://www.nabble.com/Issue-with-hggroup-and-zlim-tp19202633p19206308.html
Sent from the Octave - Bugs mailing list archive at Nabble.com.