Bug in __go_draw_axes__/do_linestyle_command

[Ben Abbott]

On Feb 24, 2008, at 3:36 PM, Ben Abbott wrote:

>
> On Feb 24, 2008, at 3:17 PM, John W. Eaton wrote:
>
>> On 24-Feb-2008, Ben Abbott wrote:
>>
>> | I've been working on modifying strcat.m so that it is consistent
>> with
>> | Matlab's. I thought I was done when I encountered a error during
>> "make".
>>
>> Have you updated your copy of the sources recently?  I think a fix  
>> for
>> this problem has already been pushed to my public archive.
>>
>> jwe
>
>
> From the web interface, I just peeked at what I believe to be the
> latest changeset 7573:05eb3486f650
> 	846	 [style, typ, with] = do_linestyle_command (obj, data_idx,
> 	847	 mono, plot_stream);
>
> I also checked my local ChangeLog. The last entry is the one below.
>
> 2008-02-21 John W. Eaton <jwe at octave.org>
> 	* image/imshow.m: Call axis ("image"). From Michael G. Ross <mgross at MIT.EDU
>> .
> 	* plot/errorbar.m: If nargout > 0, return vector of handles to line
> objects.
> 	* plot/__go_draw_axes__.m: Improve handling of line style for
> errorbar plots.
>
> In the event, I'm not current ... I've been updating my archieve by
> "hg update", is this all I need?
>
> Ben

On Feb 24, 2008, at 2:06 PM, Ben Abbott wrote:

I attempted another build with the fix below.

> 	[style, typ, with] = do_linestyle_command (obj, data_idx, mono,  
> plot_stream, "");


With this change included, I was able to build octave with the same  
results as I obtained for my last build (which includes some test  
failures).

   test_sparse.m .......................................... PASS  
1176/1184 FAIL 8
   test_string.m .......................................... PASS   77/77
   test_struct.m .......................................... PASS   22/22
   test_switch.m .......................................... PASS    6/6
   test_system.m .......................................... PASS   
107/108  FAIL 1

The system failure is always present for me, but does not occur for my  
installed octave <shrugs>.

Ben



In any event,