Bug in __go_draw_axes__/do_linestyle_command

[Ben Abbott]

On Feb 24, 2008, at 5:20 PM, Ben Abbott wrote:

>
> On Feb 24, 2008, at 3:54 PM, John W. Eaton wrote:
>
>> On 24-Feb-2008, Ben Abbott wrote:
>>
>> | With this change included, I was able to build octave with the same
>> | results as I obtained for my last build (which includes some test
>> | failures).
>> |
>> |    test_sparse.m .......................................... PASS
>> | 1176/1184 FAIL 8
>> |    test_string.m ..........................................  
>> PASS   77/77
>> |    test_struct.m ..........................................  
>> PASS   22/22
>> |    test_switch.m ..........................................  
>> PASS    6/6
>> |    test_system.m .......................................... PASS
>> | 107/108  FAIL 1
>>
>> I don't see these problems with my current sources.  All the  
>> changes I
>> have are in the public copy of my archive.
>>
>> | The system failure is always present for me, but does not occur  
>> for my
>> | installed octave <shrugs>.
>>
>> What is in the log file about that error?
>>
>> jwe
>
> I just finished my manual build, with no unexpected errors.
>
> 	Summary:
>
> 	  PASS   4032
> 	  FAIL      0
>
> 	There were 2 expected failures (see fntests.log for details).
>
> My build included my mods respecting strcat/cstrcat as well as the  
> change to __go_draw_axis__.m
>
> Ben
>


At the moment it appears to me that __go_draw_axes__.m contains the  
following lines
846		[style, typ, with] = do_linestyle_command (obj, data_idx,
847				mono, plot_stream);

If my local version is fooling me, please let me know.
In any event, I'm unfamiliar with this code, but am happy to produce a  
changeset. What is the proper approach.

(1) Pass an errbars

	[style, typ, with] = do_linestyle_command (obj, data_idx, mono,
plot_stream, "");

(2) Pass the errbars variable

	[style, typ, with] = do_linestyle_command (obj, data_idx, mono,
plot_stream, errbars);

(3) or should a check be made in do_linestyle_command?

	if (nargin < 5)
		errbars = "";
	endif

Ben