[CHANGESET] STRCAT is not compatible

Ben Abbott bpabbott at mac.com
Tue Feb 26 06:34:32 CST 2008


On Feb 26, 2008, at 2:22 AM, John W. Eaton wrote:

> On 25-Feb-2008, Ben Abbott wrote:
>
> | I've attached rather large changeset that (1) renames strcat.m to  
> cstrcat.m, (2) modifies all calls to strcat to respect cstrcat, and  
> (3) adds the new strcat.m which is compatible with Matlab's.
> |
> | I wrote a shell script to handle the entire process, so if  
> something needs to be done differently it should be a rather simple  
> matter to take care of it.
>
> You should use hg rename and the -git option for hg export so that the
> changeset will have this information in it.  Without that, I don't
> think changes can be tracked across renames.
>
> Should we really change every call of strcat?
>
> jwe

John,

I can use "hg rename" (I'll just make the change to my shell script).  
I'll do that and then build octave using your current sources.

Regarding every strcat, I prefer the global approach since I can  
automate the process, and hope not to introduce bugs.

Ben


More information about the Bug-octave mailing list