[CHANGESET] STRCAT is not compatible

[Ben Abbott]

On Feb 26, 2008, at 7:34 AM, Ben Abbott wrote:

>
> On Feb 26, 2008, at 2:22 AM, John W. Eaton wrote:
>
>> On 25-Feb-2008, Ben Abbott wrote:
>>
>> | I've attached rather large changeset that (1) renames strcat.m to
>> cstrcat.m, (2) modifies all calls to strcat to respect cstrcat, and
>> (3) adds the new strcat.m which is compatible with Matlab's.
>> |
>> | I wrote a shell script to handle the entire process, so if
>> something needs to be done differently it should be a rather simple
>> matter to take care of it.
>>
>> You should use hg rename and the -git option for hg export so that  
>> the
>> changeset will have this information in it.  Without that, I don't
>> think changes can be tracked across renames.
>>
>> Should we really change every call of strcat?
>>
>> jwe
>
> John,
>
> I can use "hg rename" (I'll just make the change to my shell script).
> I'll do that and then build octave using your current sources.
>
> Regarding every strcat, I prefer the global approach since I can
> automate the process, and hope not to introduce bugs.
>
> Ben

I just finished my build.

I did encounter 6 test failures (fntests.log is attached).

src/DLD-FUNCTIONS/rand.cc .............................. PASS 51/57  
FAIL 6

Each failure is accompanied by something like

   ***** test
  randg("state",12)
!!!!! test failed
error: rand: invalid distribution
shared variables {
   __random_statistical_tests__ = 0
}

I'm not familiar with the rand functions, so I don't know what this  
refers to. However, the problem appears to be easily duplicated at the  
octave prompt.

octave:1> randg("state",12)
error: rand: invalid distribution
error: caught execution error in library function
octave:1>

In any event, I don't see how my changes may have resulted in these  
failures (correct me if I'm wrong).

I hadn't tried a build without the strcat modifications before  
building with them. So I'll do that now. However, if anyone has  
encountered the same errors, please let me know!

Thanks
Ben