Frobenius norm of a null matrix is not zero (patch & changelog)

Ben Abbott bpabbott at mac.com
Mon Jan 14 19:31:57 CST 2008


On Jan 14, 2008, at 7:14 PM, John W. Eaton wrote:

> On 14-Jan-2008, Ben Abbott wrote:
>
> | Ok. It sounds like you're version is to be preferred over the one
> | submitted by jfc, correct?
> |
> | If so perhaps a patch and changelog can be created?
> |
> | It would also be useful to add some test scripts. If you're
> | unfamiliar with those I can add them. I just need some examples of
> | how __norm__ is used.
>
> It would be helpful if you could submit a new patch that reconciles
> the two proposed patches and includes a ChangeLog entry.
>
> Thanks,
>
> jwe

I looked up the Frobenius norm ... a rather simple calculation.

I've attached the patch and ChangeLog. Both jfc's and Rolf's changes  
fixed the bug.
Rolf went further and modified the transpose operators to avoid the  
time needed for
the conjugate. I added some tests.

	2008-01-11  Ben Abbott <bpabbott at mac.com>

	* linear-algebra/__norm__.m: Bug fix. norm (X, "fro") now works in the
	event that  X is a matrix of zeros. Tabs were converted to spaces
	to ensure consistent formatting. Some transpose operators ("'") were
	converted to the non-conjugate form (".'") to save time. Added tests.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: __norm__.diff
Type: application/octet-stream
Size: 2136 bytes
Desc: not available
Url : https://www.cae.wisc.edu/pipermail/bug-octave/attachments/20080114/22afca3f/attachment.obj 
-------------- next part --------------



More information about the Bug-octave mailing list