[OctDev] FW: upfirdn bug (was resample bug)

[Michael Goffioul]

On Wed, Jun 4, 2008 at 12:05 PM, David Bateman
<David.Bateman at motorola.com> wrote:
> Ok, I tried this example on
>
> Mandriva 2008.0, x86_64 octave developmen head, gcc 4.2.2: Ok (valgrind
> reported no errors)
> Windows XP MSVC 2005, x86, Octave 3.0.1: Crash !!
>
> So yes I can confirm this problem, but as I don't have a windows
> development environment I'm incapable of debugging the issue. Maybe
> Michael will be able to respond to this.

After debugging, it appears the problem is due to the missing "return" statement
in upfirdn. Adding a "return retval;" at the end of the function
solves the problem.
I commited a fix to SVN (plus a typo fix). I'll try to generate an
update for the
binary release, but this may take a while as I have a lot of work for
the moment.

Michael.