failed build with current mercurial sources

[Ben Abbott]

On Mar 10, 2008, at 11:19 PM, John W. Eaton wrote:

> On 10-Mar-2008, Ben Abbott wrote:
>
> |
> | On Mar 10, 2008, at 6:49 PM, John W. Eaton wrote:
> |
> | > On 10-Mar-2008, Jaroslav Hajek wrote:
> | >
> | > | On Mon, Mar 10, 2008 at 6:32 PM, John W. Eaton <jwe at bevo.che.wisc.edu
> | > > wrote:
> | > | > On  9-Mar-2008, Jaroslav Hajek wrote:
> | > | >
> | > | >  | I can't decide whether these declaration should be fixed
> | > throughout
> | > | >  | libcruft - it certainly has advantages (like enabling -
> | > fbounds-check
> | > | >  | and F77 conformance) but diverting from original sources of
> | > LSODE etc.
> | > | >  | may be a drawback.
> | > | >
> | > | >  I checked in the following change.  Send a patch if you find
> | > others.
> | > |
> | > | Is this in the public repo (www.octave.org/hg/octave) already?
> | >
> | > It should be there now.
> | >
> | > jwe
> |
> | I attempted to compile the current tip, but ...
> |
> | g++ -c -g -I/sw/include -I/sw/include -fPIC -I. -I.. -I../ 
> liboctave -
> | I../src -I../libcruft/misc  -DHAVE_CONFIG_H -mieee-fp -Wall -W -
> | Wshadow -Wold-style-cast -g -O3 mex.cc -o pic/mex.o
> | mex.cc: In constructor ?mxArray_number::mxArray_number(mwSize, const
> | char**)?:
> | mex.cc:1165: warning: comparison between signed and unsigned integer
> | expressions
> | mex.cc: In function ?mxArray* mxCreateLogicalScalar(int)?:
> | mex.cc:2549: error: ISO C++ says that these are ambiguous, even  
> though
> | the worst conversion for the first is better than the worst  
> conversion
> | for the second:
> | mex.cc:1999: note: candidate 1: mxArray::mxArray(mwSize, mwSize)
> | mex.cc:1969: note: candidate 2: mxArray::mxArray(mxClassID, double)
> | mex.cc:2549: error: ISO C++ says that these are ambiguous, even  
> though
> | the worst conversion for the first is better than the worst  
> conversion
> | for the second:
> | mex.cc:1999: note: candidate 1: mxArray::mxArray(mwSize, mwSize)
> | mex.cc:1972: note: candidate 2: mxArray::mxArray(mxClassID,  
> mxLogical)
> | make[2]: *** [pic/mex.o] Error 1
> | make[1]: *** [src] Error 2
> | make: *** [all] Error 2
> |
> | Can anyone confirm?
>
> I don't see the error.  What version of g++ do you have?
>
> In any case, I think the following change should be made.  Does it
> help?
>
> jwe

Yes, that worked. Thanks John.

Ben

~
~
~