[changeset] - bug and fix for surfnorm()

Ben Abbott bpabbott at mac.com
Sun Oct 19 09:56:39 CDT 2008


On Oct 18, 2008, at 6:19 PM, Ben Abbott wrote:

> I noticed that the lines below produced multiple surfaces
>
> 	surfnorm (peaks (10))
> 	surf (peaks)
>
> The problem was with the "hold on" that was needed to add the normal- 
> vectors to the surface ... and no "hold off" followed.
>
> The attached changeset fixes that.
>
> Ben
>
> <changeset-surfnorm.patch>

Dan,

I've merged your changeset with mine.

There are three differences between yours and mine. First you did a  
nicer job of using the handle properties. Second, your placement  
before the surf() command is more proper (imo). Third, I tried to  
preserve the hold state for "oldh" as well. The one instance I can  
imagine where that matters is when h==oldh and an error is encountered  
during the "unwind_protect".

I've also added an extra demo which would illustrate that the hold  
state was left on.

I've attached the changeset credited to you.

Thanks
Ben


-------------- next part --------------
A non-text attachment was scrubbed...
Name: changeset-surfnorm.patch
Type: application/octet-stream
Size: 1516 bytes
Desc: not available
Url : https://www-old.cae.wisc.edu/pipermail/bug-octave/attachments/20081019/e63a29e2/attachment.obj 
-------------- next part --------------










More information about the Bug-octave mailing list