Error running make check

John W. Eaton jwe at octave.org
Tue Jan 13 16:36:55 CST 2009


On 13-Jan-2009, Benjamin Lindner wrote:

| I tracked this down to function print_test_file_name (nm) in fntests.m.
| The statement
|    filler = repmat (".", 1, 55-length (nm));
| fails if the passed file name ("nm") is longer than 55 characters.
| 
| enclosing it in check as
| 
| diff -r a02ccd9ff482 test/fntests.m
| --- a/test/fntests.m    Mon Jan 12 15:30:27 2009 +0100
| +++ b/test/fntests.m    Tue Jan 13 21:48:12 2009 +0100
| @@ -53,7 +53,11 @@
|   endif
| 
|   function print_test_file_name (nm)
| -  filler = repmat (".", 1, 55-length (nm));
| +  if( length(nm)<55 )
| +    filler = repmat (".", 1, 55-length (nm));
| +  else
| +    filler = "";
| +  endif
|     printf ("  %s %s", nm, filler);
|   endfunction
| 
| solves the problem.
| 
| However this is only a workaround for make check.
| 
| You can also trigger the error by
|    repmat(".",1,-1);
| i.e. negative sizes as arguments.
| Should this be checked for in repmat or somewhere else?

This bug does not appear in the 3.0.3 repmat, but 

I checked in the following change.

Thanks,

jwe

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
Url: https://www-old.cae.wisc.edu/pipermail/bug-octave/attachments/20090113/166b2a80/attachment.ksh 


More information about the Bug-octave mailing list