small patch

[John W. Eaton]

On 24-Apr-2009, Peter O'Gorman wrote:

| Hi,
| 
| When we built octave on OSF/1 (with gcc) we found that though round was
| available, there was no declaration for it, so we added these to
| config.h. Z_FUNCS_AND_DECLS is so named so that Z will come later than
| the HAVE macros in config.h.
| 
| The HAVE_C99_VSNPRINTF check in src/utils.cc is just a check for gcc,
| which it turns out is wrong on HP-UX, OSF/1 and IRIX. We added a
| configure check.
| 
| The order of the libraries in LD_PRELOAD was important on Solaris, and,
| iirc, did not work with 'exec'.
| 
| GNU tar can take -x -v -f flags, but solaris tar does not. We do have
| GNU tar installed on solaris as 'gtar', some systems have it installed
| as 'gnutar', if GNU tar is required, that's fine, but there should be a
| configure test for it.
| 
| Added support for ia64-hp-hpux with gcc to configure.

What about the following change?

| Index: run-octave.in
| ===================================================================
| --- run-octave.in.orig	2009-01-16 06:46:22.000000000 +0000
| +++ run-octave.in	2009-04-22 18:31:03.883807961 +0000
| @@ -67,7 +67,7 @@
|  fi
|  
|  OCTAVE_SITE_INITFILE="$top_srcdir/scripts/startup/main-rcfile" \
| -LD_PRELOAD="$liboctinterp $liboctave $libcruft" \
| +LD_PRELOAD="$liboctave $liboctinterp $libcruft" \
|  %library_path_var%="$builddir/src:$builddir/liboctave:$builddir/libcruft:$%library_path_var%" \
| -  exec $driver "$builddir/src/octave" --no-initial-path --path="$LOADPATH" --image-path="$IMAGEPATH" --info-file="$INFOFILE" "$@"
| +  $driver "$builddir/src/octave" --no-initial-path --path="$LOADPATH" --image-path="$IMAGEPATH" --info-file="$INFOFILE" "$@"
|  

I seem to recall some discussion about the need for "exec" on some
systems, so I'm reluctant to remove it unconditionally.  Also, what
doesn't work with the original order of the libraries?  liboctave
should not depend on anything from liboctinterp, so I don't understand
why it would need to be loaded before liboctinterp.

I applied the rest of your patch as several independent changes:

  http://hg.savannah.gnu.org/hgweb/octave/rev/224634b2e6e3
  http://hg.savannah.gnu.org/hgweb/octave/rev/cd68431b395a
  http://hg.savannah.gnu.org/hgweb/octave/rev/7500cfff4728
  http://hg.savannah.gnu.org/hgweb/octave/rev/81a755db4db4

In the future, it would help if you sent separate patches/reports for
each problem instead of lumping them all together in a single patch.

Thanks,

jwe