make check recommended practice?

[John W. Eaton]

On  4-Dec-2007, David Bateman wrote:

| Moritz Borgmann wrote:
| > looks great to me! The only thing missing AFAICT is some notice to the
| > user that tests are skipped. Where should we put this?
| > 
| > Provided that I find some time, I may even volunteer to put in some
| > testif blocks. I have a pretty minimal build here without bells and
| > whistles.
| > 
| > Thanks,
| > 
| 
| Please consider the attached patch that I believe gets most of the
| sparse tests that will fail with suitesparse, prints the number of
| skipped tests for the "make check" target and a couple of other small
| things.

| 2007-12-03  David Bateman  <dbateman at free.fr>
| 
| 	* testfun/test.m: Disable "testif" test block to avoid spurious
| 	skipped test for "make check". Avoid printing variables for
| 	skipped tests.
| 
| 2007-12-03  David Bateman  <dbateman at free.fr>
| 
| 	* DLD-FUNCTIONS/luinc.cc: Make tests conditional on HAVE_UMFPACK.
| 	* DLD-FUNCTIONS/spqr.cc: Make tests conditional on HAVE_CXSPARSE/
| 
| 2007-12-03  David Bateman  <dbateman at free.fr>
| 
| 	* fntests.m: Also count the skipped tests
| 	* buil_sparse_tests.sh: As appropriate make tests conditional on
| 	HAVE_UMFPACK, HAVE_CHOLMOD and HAVE_CXSPARSE.

I checked it in.

Thanks,

jwe