stem series objects

[David Bateman]

Michael Goffioul wrote:
> I had a quick look and have several comments:
>
> 1) when adding properties like linestyle or marker, it's easier
> to use the possibility to inherit from existing property; for instance,
> you can use (see addproperty documentation)
>
>     addproperty ("linestyle", hg, "linelinestyle", "-");
>   
Ok, missed that. Consider the attached changeset that is applied after 
my previous one that uses this feature instead.

> 2) why do you need to call drawnow explicitely? Normally the axes
> limits are updated automatically when a child is added (and its
> X/Y/Z data are set); there should be no need to call drawnow.
>   
This was a hang over from the 3.0.x code where the axes limits were not 
updated till the drawnow occurred. This is also fixed in the attached 
additional changeset.

> 3) the off-by-1 error was intentional. In Matlab, callbacks are
> always called with at least 2 arguments: the handle of the object
> and an optional data specific to the event (for instance, a keypress
> event will contain information about the key pressed). Then other
> possible arguments are appended, in case the callback has the
> form {@fun, p1, p2, ...}
>   
yes, but then I saw that the function call had to have the form

function fun (h, d, f, p1, p2)

rather than

function fun (h, d, p1, p2)

as I would have expected from the documentation. Are you sure of your 
explanation? In any case I left my change to this in for now.

D.


-- 
David Bateman                                David.Bateman at motorola.com
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch8455
Url: https://www.cae.wisc.edu/pipermail/octave-maintainers/attachments/20080825/42283103/attachment.ksh