test failures for chol.cc

[Ben Abbott]

I pulled sources yesterday and built today. I encountered many new  
failures. Most result (151) because I'm missing ARPACK.

I also encountered a chol.cc test failure (lines from fntests.log  
below).

    15 >>>>> processing /Users/bpabbott/Development/mercurial/ 
octave-3.1.51/src/DLD-FUNCTIONS/chol.cc
    16   ***** test
    17  A = [2,0.2;0.2,1];
    18  issymmetric(A)
    19  min(eig(A))
    20  Ainv = inv(A);
    21  Ainv1 = cholinv(A);
    22  Ainv2 = inv(sparse(A));
    23  Ainv3 = cholinv(sparse(A));
    24  Ainv4 = spcholinv(sparse(A));
    25  assert (norm(Ainv-Ainv1),1e-10)
    26  assert (norm(Ainv-Ainv2),1e-10)
    27  assert (norm(Ainv-Ainv3),1e-10)
    28  assert (norm(Ainv-Ainv4),1e-10)
    29 !!!!! test failed
    30 assert (norm (Ainv - Ainv1),1e-10) expected
    31  1.0000e-10
    32 but got
    33 0

Perhaps, I'm missing the intent, but shouldn't the proper value be  
zero (David)?

    25  assert (norm(Ainv-Ainv1),0,1e-10)
    26  assert (norm(Ainv-Ainv2),0,1e-10)
    27  assert (norm(Ainv-Ainv3),0,1e-10)
    28  assert (norm(Ainv-Ainv4),0,1e-10)

Assuming my understanding is correct, I've attached the trivial  
changeset.

Ben


-------------- next part --------------
A non-text attachment was scrubbed...
Name: changeset-chol-tests.patch
Type: application/octet-stream
Size: 1299 bytes
Desc: not available
Url : https://www-old.cae.wisc.edu/pipermail/octave-maintainers/attachments/20081224/63313401/attachment.obj 
-------------- next part --------------