[Changeset]: Re: Problem with dbstep

[David Bateman]

John W. Eaton wrote:
> On  9-Jul-2008, David Bateman wrote:
>
> | Looking at the backtrace I assume that this is with a recent HG build..
> | Note that there were changes commited to the repository yesterday that
> | relate to these aspects. However, just testing this example it crashes
> | before and after applying these changes.
> | 
> | The fix is clearly that the pt-bp.h (MAYBE_DO_BREAKPOINT) macro has to
> | recognize that ta function is returning and not break or decrement its
> | counters. However, I'm not sure how that should be implemented. JWE what
> | is the means to check whether a function is returning in this macro?
>
> Yes, we need to decide what should happen when we are at the end of a
> function and there is no next line to step to.  As a temporary fix, it
> might be OK to just not allow stepping, but I think it would be
> better to step to the next line in the calling function (if any) or
> back to the top level prompt.  But I don't really understand the
> debugging code very well, and I don't know what the proper fix is.
>
> Also, I noticed that for the example function (which takes an argument)
>
>   dbstop test
>   test
>   dbstep
>
> also crashes Octave when it tries to print the error message and I
> don't know what the proper fix is for that either.
>   
Forget it. The fix is easy.. As far as I see we shouldn't be testing for
a breakpoint for the lvalue or rvalue of a function definition. Just
removing the MAYBE_DO_BREAKPOINT from pt-id.cc fixes the issue. Patch
attached.

D.

-- 
David Bateman                                David.Bateman at motorola.com
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch8272
Url: https://www.cae.wisc.edu/pipermail/octave-maintainers/attachments/20080709/75fca976/attachment.ksh