review needed: binary lookup

David Bateman David.Bateman at motorola.com
Thu Mar 27 06:00:56 CDT 2008


Jaroslav Hajek wrote:
> hello,
>
> I would like to implement a compiled binary search for Octave that
> would replace the current lookup m-file implementation.
> Dr. Eaton asked for an independent review of this code.
>   
I avoided trying to comment on this code in the past as the existing
lookup function isn't mine, but rather Paul Kienzle's ... However, I'd
say that it makes sense to accelerate the lookup function as its needed
for nearest and linear interpolation in all of the interpX functions and
these are used relatively often... If the code passes all of the
existing tests in use in the interpX functions, then I'd say accept it.

D.


-- 
David Bateman                                David.Bateman at motorola.com
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary



More information about the Octave-maintainers mailing list