small question about octave_value::magic_colon

John W. Eaton jwe at octave.org
Wed Feb 4 16:27:01 CST 2009


On  4-Feb-2009, Jaroslav Hajek wrote:

| hi,
| 
| while creating a patch today, I noticed that octave_value::magic_colon
| is an enum containing the magic_colon_t member, which makes it
| possible to create magic colons by octave_value idx =
| octave_value::magic_colon_t.
| 
| Now, I suppose it was meant the other way around? magic_colon_t being
| the enum type, magic_colon the member? OK if I change this?

Yes, but magic_colon_t is not a good name, so we should use something
else for the enum name and magic_colon for the enum value.  Maybe

  enum ov_magic_colon { magic_colon };

?

Thanks,

jwe


More information about the Octave-maintainers mailing list