[changeset] Re: When do I need autogen and configure?

[Thorsten Meyer]

Thorsten Meyer wrote:
> Hi,
> 
> here is an updated Changeset.
> 
> John W. Eaton wrote:
>> |  - What I don't like yet about the patch is, that I hardcoded the list of
>> | configuration files into the makefile sources (octMakefile.in and
>> | scripts/Makefile.in). I would rather copy them automatically from their original
>> | source in configure.in. Is there an easy way to do that?
> I have found a way: I have added AC_SUBST(ac_config_files) to configure.in. This
> way I can access the list of configuration files with @ac_config_files@ in
> octMakefile.in and Makefile.in.
> 
>> In your patch, configfiles is not a file target, so shouldn't it be
>> tagged as .PHONY?
> I tagged the configfiles target as .PHONY in octMakefile.in and
> scripts/Makefile.in. I left it as it is in Makefile.in (consistent with the
> other not-file targets there).
> 
> Also I have added a short description of the configfiles target to the help
> string in Makefile.
> 
> Into the make targets I have coded the following dependencies:
> 
> configure depends on
> 	configure.in
> 	*.m4
> 
> config.status depends on
> 	configure
> 
> octMakefile, Makefile (and other configuration files in ac_config_files) depend
> on their respective .in file and on config.status.
> 
> Is that correct?
> 
> Also, I use autoconf and autoheader directly in the Makefile rules for configure
> instead of calling autogen.sh. This way, the configure scripts in root and
> scripts can be updated independently.
> 
> Is it ok to push the changeset?
> 
> regards
> 
As it has been mentioned in another thread: here is an update of my changeset to 
  add make targets for the configuration (autogen, configure and Makefiles).
Compared to the older version, I moved the new targets below the all: target in 
order to prevent unwanted making of these targets.

I have this patch in my patch queue for quite a while now and it has not caused 
a  problem yet. However, I could not really test, if it does what it is indented 
for, namely, automatically rebuilding only those Makefiles etc. that need 
rebuilding: mercurial has the feature not to preserve timestamps, so with "hg 
qpush" after downloading new patches from the repository the timestamp of 
configure.in gets changed, and "make configfiles && make" will rebuild 
everything each time.

regards

Thorsten

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Make_target_Makefiles.patch
Type: text/x-patch
Size: 4633 bytes
Desc: not available
Url : https://www-old.cae.wisc.edu/pipermail/octave-maintainers/attachments/20090222/247c3ee4/attachment.bin