[Changeset] new bzip2 function

Thorsten Meyer thorsten.meyier at gmx.de
Thu Jan 1 04:32:22 CST 2009


Hi,

John W. Eaton wrote:
> +      error (sprintf("%s: extension has to be a string with finite length",
> +                     commandname));
>
> There's no need to use sprintf here since error already understands
> format strings.  So you should write
>
>   error ("%s: extension has to be a string with finite length", commandname);
>   
Thanks for the hint.

Attached, you will find a little patch which fixes the error messages in
__xzip__ and adds a few tests of the error handling.

regards

Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_xzip_error_messages.patch
Type: text/x-patch
Size: 2516 bytes
Desc: not available
Url : https://www-old.cae.wisc.edu/pipermail/octave-maintainers/attachments/20090101/bd149db2/attachment.bin 


More information about the Octave-maintainers mailing list